Let custom matcher provide clear failure messages

exercises/show-dont-tell/.gitignore

@@ -17,3 +17,4 @@ obj/
 
 ## NuGet local config (workaround for locked ~/.nuget)
 nuget.config
+*.log

exercises/show-dont-tell/tests/OrderTests/OrderStateConstraint.cs

@@ -12,9 +12,7 @@ namespace OrderTests;
 public static class Has
 {
     public static IResolveConstraint OrderState(decimal expectedTotal, decimal[] expectedLineValues)
-    {
+        => new OrderStateConstraint(expectedTotal, expectedLineValues);
-        return new OrderStateConstraint(expectedTotal, expectedLineValues);
-    }
 }
 
 public class OrderStateConstraint : Constraint
@@ -23,27 +21,54 @@ public class OrderStateConstraint : Constraint
     private readonly decimal[] _expectedLineValues;
 
     public OrderStateConstraint(decimal expectedTotal, decimal[] expectedLineValues)
-        : base($"order with total {expectedTotal} and line values [{string.Join(", ", expectedLineValues)}]")
     {
         _expectedTotal = expectedTotal;
         _expectedLineValues = expectedLineValues;
     }
 
+    public override string Description =>
+        $"order with total {_expectedTotal} and line values [{string.Join(", ", _expectedLineValues)}]";
+
     public override ConstraintResult ApplyTo<TActual>(TActual actual)
     {
         var order = (Order)(object)actual!;
         var actualTotal = order.Total;
         var actualLineValues = order.Lines.Select(l => l.Value).ToArray();
 
-        var totalMatch = actualTotal == _expectedTotal;
+        var details = new List<string>();
-        var linesMatch = actualLineValues.SequenceEqual(_expectedLineValues);
+        if (actualTotal != _expectedTotal)
+            details.Add($"Total: expected {_expectedTotal}, but was {actualTotal}");
+        if (!actualLineValues.SequenceEqual(_expectedLineValues))
+            details.Add(
+                $"Line values: expected [{string.Join(", ", _expectedLineValues)}], " +
+                $"but was [{string.Join(", ", actualLineValues)}]");
 
-        var messages = new List<string>();
+        return new OrderStateResult(this, actual!, details.Count == 0, details);
-        if (!totalMatch)
-            messages.Add($"Total: expected {_expectedTotal}, got {actualTotal}");
-        if (!linesMatch)
-            messages.Add($"Line values: expected [{string.Join(", ", _expectedLineValues)}], got [{string.Join(", ", actualLineValues)}]");
-
-        return new ConstraintResult(this, actual, totalMatch && linesMatch);
     }
-}
+
+    /// <summary>
+    /// A ConstraintResult that carries the per-field mismatch details and
+    /// writes them as additional lines in the failure message, e.g.
+    ///
+    ///   Expected: order with total 210 and line values [160, 50]
+    ///   But was:  &lt;Order&gt;
+    ///     Total: expected 210, but was 250
+    ///     Line values: expected [160, 50], but was [200, 50]
+    /// </summary>
+    private sealed class OrderStateResult : ConstraintResult
+    {
+        private readonly IReadOnlyList<string> _details;
+
+        public OrderStateResult(Constraint constraint, object? actual, bool isSuccess, IReadOnlyList<string> details)
+            : base(constraint, actual, isSuccess)
+        {
+            _details = details;
+        }
+
+        public override void WriteAdditionalLinesTo(MessageWriter writer)
+        {
+            foreach (var detail in _details)
+                writer.WriteMessageLine(detail);
+        }
+    }
+}

exercises/show-dont-tell/tests/OrderTests/OrderTests.csproj

@@ -7,8 +7,8 @@
   </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
-    <PackageReference Include="NUnit" Version="3.13.3" />
+    <PackageReference Include="NUnit" Version="4.6.1" />
-    <PackageReference Include="NUnit3TestAdapter" Version="4.6.0" />
+    <PackageReference Include="NUnit3TestAdapter" Version="6.3.0" />
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\..\src\OrderDomain\OrderDomain.csproj" />

exercises/show-dont-tell/tests/OrderTests/OrderTotalTests.cs

@@ -18,7 +18,7 @@ public class OrderTotalTests
 
         Assert.That(order, Has.OrderState(
             expectedTotal: 210m,
-            expectedLineValues: new[] { 160m, 50m }));
+             expectedLineValues: [160m, 50m]));
     }
 
     [Test]