Add agent rehearsal harness, findings, and per-run evidence for split-loop-with-lambda

Six scripted pi sub-agent runs (3 tool regimes × 2 models) rehearsed the exercise; deterministic gate = solution test + approved file. Key results: mandated CLI triples cost on the strong model (4:06 vs 0:39, PASS both); weak model fails only under the mandate (A+Q), passes when free or optional. Drift documented with code: scorer.updateSelection left inside the extracted method (A+Q, C+Q). Harness in tools/rehearse; summary in rehearsal-findings.md; per-run evidence in rehearsal-runs/; cheat sheet in rehearse-with-agent.md corrected (lambda-typed parameters unsupported).
2026-09-27 17:36:19 +00:00
parent a27e32688a
commit b993f25c53
51 changed files with 2281 additions and 2 deletions
@@ -0,0 +1,71 @@
+The test compilation error is expected — the test still calls the old `longRangeForecast("Q1")` signature which has been replaced by the no-arg overload and the new `LongFunction<Boolean>` parameterized version, per the task requirements. The AGENTS.md notes that test failures are expected.
+
+---
+
+## Refactoring complete. Final diff of `LongRangeForecasts.java`:
+
+```diff
+ import java.util.*;
+import java.util.function.LongFunction;
+
+ public class LongRangeForecasts {
+
+     private final Scorer scorer = new Scorer();
+
+-    public Map<IceCream, Integer> longRangeForecast(String quarter) {
+    public Map<IceCream, Integer> longRangeForecast() {
+        return longRangeForecast(d -> scorer.lookupWeather(d));
+    }
+
+    public Map<IceCream, Integer> longRangeForecast(LongFunction<Boolean> dayOffsetToWeather) {
+         var result = new HashMap<IceCream, Integer>();
+-        if (Objects.equals(quarter, "Q1") || Objects.equals(quarter, "Q4")) {
+-            for (IceCream flavour : IceCream.values()) {
+-                result.put(flavour, 5);
+-            }
+-        }
+         for (IceCream flavour : IceCream.values()) {
+             result.put(flavour, 0);
+         }
+@@ -25,15 +24,7 @@
+                 Instant.parse("2023-06-05T14:00:00.000-07:00"),
+                 Instant.parse("2023-06-23T14:00:00.000-07:00")
+         );
+-        List<Boolean> expectedWeather = new ArrayList<>();
+-        for (Instant interestingDate : interestingDates) {
+-            scorer.updateSelection();
+-            var forecastDate = Instant.parse("2023-04-26T14:00:00.000-07:00");
+-            long daysForward = ChronoUnit.DAYS.between(forecastDate, interestingDate);
+-            Boolean lookupWeather = scorer.lookupWeather(daysForward);
+-            expectedWeather.add(lookupWeather);
+-        }
+-
+        List<Boolean> expectedWeather = collectExpectedWeather(interestingDates, dayOffsetToWeather);
+         for (IceCream flavour : result.keySet()) {
+             result.put(flavour, result.get(flavour) + 10);
+             var sunnyHolidays = expectedWeather.stream().filter(s -> s).count();
+@@ -46,4 +37,15 @@
+         }
+         return result;
+     }
+
+    private List<Boolean> collectExpectedWeather(List<Instant> dates, LongFunction<Boolean> dayOffsetToWeather) {
+        List<Boolean> expectedWeather = new ArrayList<>();
+        for (Instant date : dates) {
+            scorer.updateSelection();
+            var forecastDate = Instant.parse("2023-04-26T14:00:00.000-07:00");
+            long daysForward = ChronoUnit.DAYS.between(forecastDate, date);
+            expectedWeather.add(dayOffsetToWeather.apply(daysForward));
+        }
+        return expectedWeather;
+    }
+ }
+```
+
+## Summary of changes:
+
+| Step | Change |
+|------|--------|
+| **1** | Added `import java.util.function.LongFunction`; introduced `dayOffsetToWeather` lambda wrapping `scorer.lookupWeather()` in the original method body, replacing direct scorer calls |
+| **2** | Extracted the weather-collection loop into a new `private List<Boolean> collectExpectedWeather(List<Instant>, LongFunction<Boolean>)` method |
+| **3** | Removed `String quarter` parameter; added a **no-arg** `longRangeForecast()` that delegates to the parameterized overload wrapping the `scorer`; renamed the main method to accept `LongFunction<Boolean> dayOffsetToWeather` |