From 73f6ca50498f7a5abbe3a7616a5c792e30610cd0 Mon Sep 17 00:00:00 2001 From: Willem van den Ende Date: Tue, 5 May 2026 19:46:18 +0100 Subject: [PATCH] remove integration test that was too specific --- .gitignore | 1 + AGENTS.md | 9 ++++++ app/Makefile | 2 +- .../controllers/blog_tags_test.exs | 31 ------------------- 4 files changed, 11 insertions(+), 32 deletions(-) diff --git a/.gitignore b/.gitignore index 59faae5..d48b390 100644 --- a/.gitignore +++ b/.gitignore @@ -4,3 +4,4 @@ dokku-setup.sh .claude/worktrees app/priv/blog/engineering/2026/04-24-what-it-takes-to-get-started-with-the-pi-coding-agent.md /tmp_work/ +.yaks diff --git a/AGENTS.md b/AGENTS.md index 59c3ff6..1ebd356 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -7,10 +7,19 @@ When you are unsure about something, ALWAYS ask the user. we use `yx` for planning run yx --help to see options. Invoke when the user wants to make a plan, work on something for a plan or mentions 'yak' or 'yaks'. +`yx list` - shows open yaks +`yx add` - adds yaks + # Building This is a Phoenix Liveview monorepo, the blogging library is in blogex, the application is in 'app'. Use `make` to build and `brief` to find out more about mix. +Main make targets: + +- make test +- make check - runs credo static analysis and suggests refactorings + + # Development Always fix failing tests, credo issues and format isseus. diff --git a/app/Makefile b/app/Makefile index 899b590..92f834c 100644 --- a/app/Makefile +++ b/app/Makefile @@ -1,6 +1,6 @@ # Makefile for Firehose app -MISE_BIN ?= /home/vscode/.local/bin/mise +MISE_BIN ?= $(HOME)/.local/bin/mise MISE_EXEC = $(MISE_BIN) exec -- .PHONY: check precommit deps compile test format credo diff --git a/app/test/firehose_web/controllers/blog_tags_test.exs b/app/test/firehose_web/controllers/blog_tags_test.exs index a7f9f1f..359faa0 100644 --- a/app/test/firehose_web/controllers/blog_tags_test.exs +++ b/app/test/firehose_web/controllers/blog_tags_test.exs @@ -89,35 +89,4 @@ defmodule FirehoseWeb.BlogTagsTest do assert body =~ "All posts" end end - - describe "clickable tags on index page" do - test "tags are rendered as clickable links on engineering blog index", %{ - conn: conn - } do - conn_res1 = get(conn, "/blog/engineering") - body1 = html_response(conn_res1, 200) - - # Verify tag links exist with correct href pattern - assert body1 =~ ~r{href="/blog/engineering/tag/meta"} - assert body1 =~ ~r{href="/blog/engineering/tag/ai"} - end - - test "tags are rendered as clickable links on releases blog index", %{ - conn: conn - } do - conn_res2 = get(conn, "/blog/releases") - body2 = html_response(conn_res2, 200) - - # Verify tag link exists - assert body2 =~ ~r{href="/blog/releases/tag/release"} - end - - test "tag links have proper styling classes", %{conn: conn} do - conn_res3 = get(conn, "/blog/engineering") - body3 = html_response(conn_res3, 200) - - # Verify blogex-tag-link class is present for tag links - assert body3 =~ ~r{class="[^"]*blogex-tag-link} - end - end end