fixed 11 out or 34 conn shadowing cases

11 are multi-line, script does not do that
This commit is contained in:
2026-05-05 21:26:00 +01:00
parent 73f6ca5049
commit a89d09e432
5 changed files with 180 additions and 185 deletions
@@ -3,23 +3,20 @@ defmodule FirehoseWeb.BlogControllerTest do
describe "GET /blog/:blog_id (index) - date filtering" do
test "does not show future-dated posts", %{conn: conn} do
conn = get(conn, ~p"/blog/engineering")
html = html_response(conn, 200)
html = conn |> get(~p"/blog/engineering") |> html_response(200)
refute html =~ "Future Test Post"
end
end
describe "GET /blog/:blog_id/:slug (show) - date filtering" do
test "still shows a future-dated post by slug", %{conn: conn} do
conn = get(conn, ~p"/blog/engineering/future-test-post")
assert html_response(conn, 200) =~ "Future Test Post"
assert conn |> get(~p"/blog/engineering/future-test-post") |> html_response(200) =~ "Future Test Post"
end
end
describe "GET /blog/:blog_id/tag/:tag - date filtering" do
test "excludes future-dated posts from tag page", %{conn: conn} do
conn = get(conn, ~p"/blog/engineering/tag/test")
html = html_response(conn, 200)
html = conn |> get(~p"/blog/engineering/tag/test") |> html_response(200)
refute html =~ "Future Test Post"
end
end
@@ -28,24 +25,22 @@ defmodule FirehoseWeb.BlogControllerTest do
setup :register_and_log_in_user
test "authenticated user sees draft banner on draft post", %{conn: conn} do
conn = get(conn, ~p"/blog/engineering/hello-world")
response = conn |> get(~p"/blog/engineering/hello-world")
assert html_response(conn, 200) =~ "Draft"
assert conn.resp_body =~ "not published"
assert html_response(response, 200) =~ "Draft"
assert response.resp_body =~ "not published"
end
test "authenticated user sees scheduled banner on future post", %{conn: conn} do
conn = get(conn, ~p"/blog/engineering/future-test-post")
response = conn |> get(~p"/blog/engineering/future-test-post") |> html_response(200)
response = html_response(conn, 200)
assert response =~ "scheduled for"
assert response =~ "January 01, 2099"
end
test "authenticated user sees no banner on live post", %{conn: conn} do
conn = get(conn, ~p"/blog/engineering/why-firehose")
response = conn |> get(~p"/blog/engineering/why-firehose") |> html_response(200)
response = html_response(conn, 200)
refute response =~ "Draft"
refute response =~ "scheduled for"
end