fixed 11 out or 34 conn shadowing cases

11 are multi-line, script does not do that

app/test/firehose_web/controllers/user_session_controller_test.exs

@@ -10,8 +10,7 @@ defmodule FirehoseWeb.UserSessionControllerTest do
 
   describe "GET /users/log-in" do
     test "renders login page", %{conn: conn} do
-      conn = get(conn, ~p"/users/log-in")
-      response = html_response(conn, 200)
+      response = conn |> get(~p"/users/log-in") |> html_response(200)
       assert response =~ "Log in"
       assert response =~ ~p"/users/register"
       assert response =~ "Log in with email"
@@ -33,8 +32,7 @@ defmodule FirehoseWeb.UserSessionControllerTest do
     end
 
     test "renders login page (email + password)", %{conn: conn} do
-      conn = get(conn, ~p"/users/log-in?mode=password")
-      response = html_response(conn, 200)
+      response = conn |> get(~p"/users/log-in?mode=password") |> html_response(200)
       assert response =~ "Log in"
       assert response =~ ~p"/users/register"
       assert response =~ "Log in with email"
@@ -48,8 +46,7 @@ defmodule FirehoseWeb.UserSessionControllerTest do
           Accounts.deliver_login_instructions(user, url)
         end)
 
-      conn = get(conn, ~p"/users/log-in/#{token}")
-      assert html_response(conn, 200) =~ "Confirm and stay logged in"
+      assert conn |> get(~p"/users/log-in/#{token}") |> html_response(200) =~ "Confirm and stay logged in"
     end
 
     test "renders login page for confirmed user", %{conn: conn, user: user} do
@@ -58,17 +55,16 @@ defmodule FirehoseWeb.UserSessionControllerTest do
           Accounts.deliver_login_instructions(user, url)
         end)
 
-      conn = get(conn, ~p"/users/log-in/#{token}")
-      html = html_response(conn, 200)
+      html = conn |> get(~p"/users/log-in/#{token}") |> html_response(200)
       refute html =~ "Confirm my account"
       assert html =~ "Keep me logged in on this device"
     end
 
     test "raises error for invalid token", %{conn: conn} do
-      conn = get(conn, ~p"/users/log-in/invalid-token")
-      assert redirected_to(conn) == ~p"/users/log-in"
+      response = conn |> get(~p"/users/log-in/invalid-token")
+      assert redirected_to(response) == ~p"/users/log-in"
 
-      assert Phoenix.Flash.get(conn.assigns.flash, :error) ==
+      assert Phoenix.Flash.get(response.assigns.flash, :error) ==
                "Magic link is invalid or it has expired."
     end
   end
@@ -190,10 +186,10 @@ defmodule FirehoseWeb.UserSessionControllerTest do
     end
 
     test "succeeds even if the user is not logged in", %{conn: conn} do
-      conn = delete(conn, ~p"/users/log-out")
-      assert redirected_to(conn) == ~p"/"
-      refute get_session(conn, :user_token)
-      assert Phoenix.Flash.get(conn.assigns.flash, :info) =~ "Logged out successfully"
+      response = conn |> delete(~p"/users/log-out")
+      assert redirected_to(response) == ~p"/"
+      refute get_session(response, :user_token)
+      assert Phoenix.Flash.get(response.assigns.flash, :info) =~ "Logged out successfully"
     end
   end
 end