yak(credo-strict-tuned-config-both-apps-x02d): credo strict, tuned config (both apps)

app/.credo.exs

@@ -4,6 +4,13 @@
 # If you find anything wrong or unclear in this file, please report an
 # issue on GitHub: https://github.com/rrrene/credo/issues
 #
+# The gate for this app is `mix credo --strict` on the command line (the
+# `credo` target in Makefile, a prerequisite of `check`). The command line, not
+# this file, decides: `--strict` overrides the inert `strict: false` key below.
+# Editing `strict` here to silence a finding would change nothing - fix the
+# finding, or write down why the check is wrong for this codebase (see
+# `disabled:`).
+#
 %{
   #
   # You can have as many configs as you like in the `configs:` field.
@@ -126,7 +133,6 @@
           #
           {Credo.Check.Refactor.Apply, []},
           {Credo.Check.Refactor.CondStatements, []},
-          {Credo.Check.Refactor.CyclomaticComplexity, []},
           {Credo.Check.Refactor.FilterCount, []},
           {Credo.Check.Refactor.FilterFilter, []},
           {Credo.Check.Refactor.FunctionArity, []},
@@ -174,6 +180,18 @@
           {Firehose.Checks.NoConnShadowing, []}
         ],
         disabled: [
+          #
+          # Our one deliberate deviation from credo's defaults. CRAP (`ex_crap`,
+          # threshold 30, wired into the Lens pass in Makefile) is this app's
+          # complexity sensor, and it scores complexity against real coverage: a
+          # wide `case` that the tests exercise is not a problem - that was the
+          # itch behind ExCrap. A second, coverage-blind complexity sensor would
+          # just argue with the first, so complexity questions are settled by
+          # the CRAP target. Re-enabling this check without retiring the CRAP
+          # target is a policy change, not a cleanup.
+          #
+          {Credo.Check.Refactor.CyclomaticComplexity, []},
+
           #
           # Checks scheduled for next check update (opt-in for now)
           {Credo.Check.Refactor.UtcNowTruncate, []},