From f54ce2fab78253422d71ca283f3501ebfe23eddc Mon Sep 17 00:00:00 2001 From: Willem van den Ende Date: Mon, 26 Oct 2026 19:50:47 +0000 Subject: [PATCH] app: note that CoreComponents.table/1 and list/1 are unused upstream scaffold These two come from the upstream Phoenix generator and are worth keeping for future data/admin screens, so they stay rather than being deleted as dead code. The note also records why they look unused but aren't pointless: the collections already in the UI are hand-rolled (editor_dashboard_live's drafts/scheduled rows are bordered divs; Blogex.Components.post_index renders post previews and tag lists itself). That is the fact a future reader needs before either deleting these or writing yet another bespoke list. --- app/lib/firehose_web/components/core_components.ex | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/app/lib/firehose_web/components/core_components.ex b/app/lib/firehose_web/components/core_components.ex index d0be6c1..cd03ca6 100644 --- a/app/lib/firehose_web/components/core_components.ex +++ b/app/lib/firehose_web/components/core_components.ex @@ -303,6 +303,16 @@ defmodule FirehoseWeb.CoreComponents do """ end + # `table/1` and `list/1` below are part of the upstream Phoenix generator's + # core_components.ex and are kept available for when we need them — they are + # genuinely useful, not leftover scaffolding to be deleted. + # + # Nothing renders them yet: the collections that exist in the UI are hand-rolled + # instead (editor_dashboard_live.ex builds its drafts/scheduled rows out of + # bordered divs; Blogex.Components.post_index renders post previews and tag + # lists as articles/links). If you build a new data or admin screen, prefer + # these two over more bespoke markup — and if you retrofit an existing screen, + # drop the note here. @doc """ Renders a table with generic styling. @@ -366,6 +376,7 @@ defmodule FirehoseWeb.CoreComponents do """ end + # Upstream scaffold, unused in-app today — see the note above `table/1`. @doc """ Renders a data list.