From b6696a4f6ca66d76ceeadff016715ebc8aa36ae5 Mon Sep 17 00:00:00 2001
From: Willem van den Ende <willem@qwan.eu>
Date: Sun, 28 Jun 2026 12:04:23 +0200
Subject: [PATCH] Rename, tests Fail, not Error

Parsing no longer depends on ui widget
---
 pi-test-status/extensions/index.ts                            | 2 +-
 .../extensions/parsing/__tests__/vitest-output.test.ts        | 4 ++--
 .../extensions/parsing/typescript-command-output.ts           | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/pi-test-status/extensions/index.ts b/pi-test-status/extensions/index.ts
index 39e2166..2fcc04e 100644
--- a/pi-test-status/extensions/index.ts
+++ b/pi-test-status/extensions/index.ts
@@ -19,7 +19,7 @@ export default function testStatusExtension(pi: ExtensionAPI) {
             ctx.ui.setWidget("test-status", [
                 `${theme.fg("success", "●")} ${theme.fg("text", testResult.summary)}`,
             ]);
-        } else if (testResult.status === "Error" || event.isError) {
+        } else if (testResult.status === "Fail" || event.isError) {
             ctx.ui.setWidget("test-status", [
                 `${theme.fg("error", "●")} ${theme.fg("text", testResult.summary)}`,
             ]);
diff --git a/pi-test-status/extensions/parsing/__tests__/vitest-output.test.ts b/pi-test-status/extensions/parsing/__tests__/vitest-output.test.ts
index 40ae035..26381b5 100644
--- a/pi-test-status/extensions/parsing/__tests__/vitest-output.test.ts
+++ b/pi-test-status/extensions/parsing/__tests__/vitest-output.test.ts
@@ -35,14 +35,14 @@ describe("parseTestOutput", () => {
 
     const result = parseTestOutput(output);
 
-    expect(result.status).toBe("Error");
+    expect(result.status).toBe("Fail");
     expect(result.summary).toContain("1 failed");
   });
 
   it("returns Error and a fallback summary for unrecognised output", () => {
     const result = parseTestOutput("some random output");
 
-    expect(result.status).toBe("Error");
+    expect(result.status).toBe("Fail");
     expect(result.summary).toBe("Tests failed");
   });
 
diff --git a/pi-test-status/extensions/parsing/typescript-command-output.ts b/pi-test-status/extensions/parsing/typescript-command-output.ts
index 1fc94bc..aa92b6e 100644
--- a/pi-test-status/extensions/parsing/typescript-command-output.ts
+++ b/pi-test-status/extensions/parsing/typescript-command-output.ts
@@ -1,6 +1,6 @@
 export type TestResult =
   | { status: "Success"; summary: string }
-  | { status: "Error"; summary: string };
+  | { status: "Fail"; summary: string };
 
 export const isTestCommand = (command: string) => {
   return command.includes("npm test") || command.includes("vitest");
@@ -21,5 +21,5 @@ export function parseTestOutput(output: string): TestResult {
   const line = output
     .split("\n")
     .find((l) => /Tests\s+.+failed/.test(l));
-  return { status: "Error", summary: line?.trim() ?? "Tests failed" };
+  return { status: "Fail", summary: line?.trim() ?? "Tests failed" };
 }