lib/basic_signup_whitelist.ex

@@ -18,12 +18,8 @@ defmodule BasicSignupWhitelist do
 
   ## Examples
 
-      iex> System.delete_env("SIGNUP_ALLOWED_EMAILS")
       iex> BasicSignupWhitelist.mail_whitelisted("joe@example.com")
       false
-      iex> System.put_env("SIGNUP_ALLOWED_EMAILS","*")
-      iex> BasicSignupWhitelist.mail_whitelisted("joe@example.com")
-      true
 
   """
   def mail_whitelisted(email) do

test/basic_signup_whitelist_test.exs

@@ -1,29 +1,33 @@
 defmodule BasicSignupWhitelistTest do
-  use ExUnit.Case, async: false
+  use ExUnit.Case
   doctest BasicSignupWhitelist
 
   defp allow_signups_for(whitelist) do
     System.put_env("SIGNUP_ALLOWED_EMAILS", whitelist)
   end
 
-  describe "setup in describe block" do
+  setup do
-    setup do
+    # Save original env var
-      on_exit(fn ->
+    original_env = System.get_env("SIGNUP_ALLOWED_EMAILS")
-        # resetting values did not work, so 'just' set it to the effect without this module configured.
-        System.put_env("SIGNUP_ALLOWED_EMAILS", "*")
-      end)
 
-      :ok
+    on_exit(fn ->
-    end
+      # Restore original env var after each test
+      case original_env do
+        nil -> System.delete_env("SIGNUP_ALLOWED_EMAILS")
+        value -> System.put_env("SIGNUP_ALLOWED_EMAILS", value)
+      end
+    end)
 
-    test "When not set, not whitelisted" do
+    :ok
-      System.delete_env("SIGNUP_ALLOWED_EMAILS")
+  end
-      refute BasicSignupWhitelist.mail_whitelisted("joe@example.com")
-    end
 
-    test "When set to star, whitelisted" do
+  test "When not set, not whitelisted" do
-      allow_signups_for("*")
+    System.delete_env("SIGNUP_ALLOWED_EMAILS")
-      assert BasicSignupWhitelist.mail_whitelisted("joe@example.com")
+    refute BasicSignupWhitelist.mail_whitelisted("joe@example.com")
-    end
+  end
+
+  test "When set to star, whitelisted" do
+    allow_signups_for("*")
+    assert BasicSignupWhitelist.mail_whitelisted("joe@example.com")
   end
 end